-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the raw format for 48-chan feds, back to the old one #16164
Conversation
A new Pull Request was created by @dkotlins for CMSSW_8_1_X. It involves the following packages: EventFilter/SiPixelRawToDigi @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@dkotlins |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Slava,
|
On 10/10/16 12:01 PM, dkotlins wrote:
Hi Danek, we have pre12 relval samples. This particular change doesn't look like a typical cabling map change.
|
Slava,
|
+1 Changing 2017 Pixel RAW format to support only 48-channel FEDs instead of 96 channels that won't be needed. There should be no change in monitored quantities. The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-10-10-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
Change back phase1 raw-fed format to what is used for phase0.
With 48-channel FEDs we do not need the new format.
Needs the new (post 8_1_0_pre12) phase1 MC GTs.